Went ahead and used CharsetUtil.getUtf8Bytes(...), and committed. On Mon, May 3, 2010 at 4:43 PM, John Hjelmstad <[email protected]> wrote:
> I suppose it couldn't hurt to just use CharsetUtil.getUtf8Bytes() - > obviates the need for a try/catch block as well. Seem reasonable? > > On Mon, May 3, 2010 at 4:39 PM, <[email protected]> wrote: > >> >> http://codereview.appspot.com/1032042/diff/1/2 >> File >> >> >> java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/MutableContent.java >> (right): >> >> http://codereview.appspot.com/1032042/diff/1/2#newcode144 >> >> java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/MutableContent.java:144: >> contentBytes = content.getBytes("UTF8"); >> Just curious is the charset name should be "UTF-8" or use >> CharsetUtil.UTF8? >> >> >> http://codereview.appspot.com/1032042/show >> > >
