http://codereview.appspot.com/1147041/diff/1/3
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java
(right):

http://codereview.appspot.com/1147041/diff/1/3#newcode91
java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java:91:
};
no change in this file (except whitespace)?

http://codereview.appspot.com/1147041/diff/1/4
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateModule.java
(right):

http://codereview.appspot.com/1147041/diff/1/4#newcode24
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateModule.java:24:
import com.google.inject.multibindings.Multibinder;
ordering... right?

http://codereview.appspot.com/1147041/diff/1/4#newcode54
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateModule.java:54:
tagBinder.addBinding().to(VariableTagHandler.class);
I can see the value here when adding multiple bindings from different
sources, but is there much vs. the previous model in this case?

http://codereview.appspot.com/1147041/show

Reply via email to