Reviewers: johnfargo, zhoresh, shindig.remailer_gmail.com,
dev-remailer_shindig.apache.org,
Message:
On 2010/06/17 19:40:12, zhoresh wrote:
Lgtm, but do you really need the new rewriter class?
You can just instantiate the DomWalker.Rewriter with the visitor in
the
constructor.
As discussed, keeping the rewriter class for consistency, but making it
similar to StyleAdjacencyContentRewriter
Description:
1) Adding AbsolutePathReferenceRewriter which will convert all urls to
absolute.
2) Refactoring AbsolutePathReferenceVisitor so it is easier to extend it
and reuese the basic functionality of extracting all relevant uri's and
processing them.
Please refer to http://codereview.appspot.com/1674041/show for example
of DomainBalancingUriVisitor which extends AbsolutePathReferenceVisitor.
Please review this at http://codereview.appspot.com/1699041/show
Affected files:
A
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/AbsolutePathReferenceRewriter.java
M
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/AbsolutePathReferenceVisitor.java
