On Thu, Jun 17, 2010 at 2:38 PM, <[email protected]> wrote: > > http://codereview.appspot.com/1697041/diff/1/2 > File config/container.js (right): > > http://codereview.appspot.com/1697041/diff/1/2#newcode95 > config/container.js:95: "defaultShindigTestHost": > "http://localhost:9003";, > On 2010/06/17 21:30:14, johnfargo wrote: > >> why not just remove http:// from this URL and call it a day then? >> > > i havent tested DefaultIframeUriManager but maybe your right that it > will run into similar errors. > Check out: > > http://www.google.com/codesearch/p?hl=en#gYyO98kxBCI/carbon/dependencies/shindig/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java&q=%22gadgets.uri.iframe.unlockedDomain%22&sa=N&cd=1&ct=rc&l=46 > line #112 > > we are doing the same thing, reading a host name and passing > "http://hostname"; from config. > > Next time i run into similar errors, il remove the http from all > occuarances in this file.
I wouldn't go that far - but removing http:// (scheme) from tokens that are used in code purely as host/authority is clearly the right thing to do. defaultShindigTestHost is only ever used here in this config, not in code, so what we're really fixing are the gadgets.uri.proxy.host and gadgets.uri.concat.host values. > > > http://codereview.appspot.com/1697041/show >
