On 2010/06/21 18:18:58, Paul Lindner wrote:
can you please retain the previous method of setting the proxy from
environment
variables? It can be used when there is no proxy set via guice.
I know there are some people using that feature and removing this
would break
them. Otherwise looks good.
Thanks!
Hi Paul
Im not sure i understood what you meant by previous method of setting
proxy from environment variables.
Do you want me to keep the following block in case proxy is not
specified using shindig.properties?
// Use Java's built-in proxy logic
if (StringUtils.isEmpty(basicHttpFetcherProxy)) {
ProxySelectorRoutePlanner routePlanner = new
ProxySelectorRoutePlanner(
client.getConnectionManager().getSchemeRegistry(),
ProxySelector.getDefault());
client.setRoutePlanner(routePlanner);
}
http://codereview.appspot.com/1635042/show
