Reviewers: johnfargo, zhoresh, dev-remailer_shindig.apache.org,
shindig.remailer_gmail.com,
Message:
On 2010/06/21 20:51:03, zhoresh wrote:
http://codereview.appspot.com/1705043/diff/1/2
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java
(right):
http://codereview.appspot.com/1705043/diff/1/2#newcode59
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java:59:
protected AccelUriManager uriManager;
Maybe keep them final, and override them using injection in derived
class
Done.
Description:
Converting private final requestPipeline, responseRewriterRegistry and
uriManager to protected so that it is easy to override them when
extending HtmlAccelServlet.
Please review this at http://codereview.appspot.com/1705043/show
Affected files:
M
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java
Index:
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java
===================================================================
---
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java
(revision 956467)
+++
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java
(working copy)
@@ -54,9 +54,9 @@
static final Integer LONG_LIVED_REFRESH = (365 * 24 * 60 * 60); // 1
year
static final Integer DEFAULT_REFRESH = (60 * 60); // 1
hour
- private final RequestPipeline requestPipeline;
- private final ResponseRewriterRegistry contentRewriterRegistry;
- private final AccelUriManager uriManager;
+ protected final RequestPipeline requestPipeline;
+ protected final ResponseRewriterRegistry contentRewriterRegistry;
+ protected final AccelUriManager uriManager;
@Inject
public AccelHandler(RequestPipeline requestPipeline,
@@ -116,8 +116,8 @@
* @return Remote content request based on the parameters sent from the
client.
* @throws GadgetException In case the data could not be fetched.
*/
- private HttpRequest buildHttpRequest(HttpServletRequest request,
- ProxyUriManager.ProxyUri
uriToProxyOrRewrite)
+ protected HttpRequest buildHttpRequest(HttpServletRequest request,
+ ProxyUriManager.ProxyUri
uriToProxyOrRewrite)
throws GadgetException {
Uri tgt = uriToProxyOrRewrite.getResource();
validateUrl(tgt);
