Seems okay -- does not account for new files or changes to the
dependency graph..  Might be interesting if we support jndi resources in
the future..


http://codereview.appspot.com/1732044/diff/1/2
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/features/FeatureResourceLoader.java
(right):

http://codereview.appspot.com/1732044/diff/1/2#newcode174
java/gadgets/src/main/java/org/apache/shindig/gadgets/features/FeatureResourceLoader.java:174:
// Only check for file updates at preconfigured intervals. This prevents
truncated comment?

http://codereview.appspot.com/1732044/diff/1/2#newcode175
java/gadgets/src/main/java/org/apache/shindig/gadgets/features/FeatureResourceLoader.java:175:
lastUpdateCheckTime = timeSource.currentTimeMillis();
DRY - calculate this once before the if statement?

http://codereview.appspot.com/1732044/show

Reply via email to