Re: Adding capability in accel servlet to act as accelerating proxy (issue1712043)

[johnfargo]

LGTM, committed.

On 2010/06/22 04:59:45, gagan.goku wrote:

http://codereview.appspot.com/1712043/diff/19001/20005
File

java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/AccelUriManager.java

(right):

http://codereview.appspot.com/1712043/diff/19001/20005#newcode32

java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/AccelUriManager.java:32:

final String PROXY_PATH_PARAM =

DefaultProxyUriManager.PROXY_PATH_PARAM;

On 2010/06/22 03:36:33, johnfargo wrote:
> can be public, should be static.

Done.

http://codereview.appspot.com/1712043/diff/19001/20006
File

java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultAccelUriManager.java

(right):

http://codereview.appspot.com/1712043/diff/19001/20006#newcode46

java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultAccelUriManager.java:46:

ACCEL_PATH = config.getString(CONTAINER,
DefaultProxyUriManager.PROXY_PATH_PARAM);
On 2010/06/22 03:36:33, johnfargo wrote:
> nit: for local non-static variables, use camelCase variables

starting w/

> lowerCase letters

Done.

http://codereview.appspot.com/1712043/diff/19001/20003
File

java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/AccelUriManagerTest.java

(right):

http://codereview.appspot.com/1712043/diff/19001/20003#newcode27

java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/AccelUriManagerTest.java:27:

* TODO: Complete or remove.
On 2010/06/22 03:36:33, johnfargo wrote:
> I'd remove this now; AccelUriManager is not testable.

DefaultAccelUriManager

> however is ;)

added test for DefaultAccelUriManager. file reverted

http://codereview.appspot.com/1712043/show