Just to clarify: We currently extend Query by adding Locale and
SecurityToken fields to it, which we initialize from GadgetContext.

We require access to those fields when parsing the gadget spec that is
being queried.

So the proposal is to either make the entire GadgetContext available
from the Query (which would introduce some duplication as explained
earlier), or just the Locale and SecurityToken of the original gadget
request.


On 2010/06/23 19:22:23, janluehe wrote:
I realize that adding getter and setter methods for GadgetContext to
Query will
introduce some duplication, because Query already contains specUri,
container,
gadgetUri, and ignoreCache fields, which are also available from
GadgetContext
(but we want those fields to be individually settable on Query, and
there may
not always be a GadgetContext available when the Query object is
initialized, as
is the case when initializing a LocaleQuery in
DefaultMessageBundleFactory#getBundleFor).

How about adding setter and getter methods for Locale and
SecurityToken to
Query?



http://codereview.appspot.com/1688043/show

Reply via email to