On 2010/07/06 14:27:40, Han Nguyen wrote:
Revised patch - Mark Nesbitt to add details soon after
Overview of changes with this patch: 1: Moved all conversion logic in unnecessary locations(DefaultTemplateProcessor) and into Expressions.java. Created new interfaces for ExpressionsProvider and ELTypeConverter - and guice modules and implementations for Juel (same version) and Jasper 6.0.2.26). Default implementation is Juel to stay consistent with past code. 2: Modified expression test cases to run both Juel and Jasper expression test cases. made minor changes to other test cases to take advantage of the Juel default. 3: Formatting corrected (hopefully). 4: Reworked the Jasper work around in the code and added comments. Jasper-el has a bug where it is not possible to access variable mapper from the context passed in. Will try to open an issue with jasper-el - but it will take time to fix. The work around does not cause any issues with Juel. There might be a better way to do this work around and am open for suggestions. 5: Jasper still has an inability to do type conversions from numbers (and some String issues) to booleans involving negation/and/or operations. In the spec I could only find one reference to an item where we have a failing test case In template section here: "A Node, NodeList or non-empty string will evaluate to true'." - Jasper has issues with non-empty strings. http://codereview.appspot.com/1376043/show
