http://codereview.appspot.com/1807042/diff/5001/6003 File java/gadgets/src/test/java/org/apache/shindig/gadgets/render/HtmlRendererTest.java (right):
http://codereview.appspot.com/1807042/diff/5001/6003#newcode65 java/gadgets/src/test/java/org/apache/shindig/gadgets/render/HtmlRendererTest.java:65: if (HtmlAccelServlet.ACCEL_GADGET_PARAM_NAME.equals(name)) { Ah. In that case, the original code is incorrect by spec. The Java spec requires identical string literals must refer to the same instance of class String. I'll change A_G_P_N to new String(). On 2010/07/12 20:36:34, johnfargo wrote:
this isn't a misuse -- the ==-check ensures that a requestor cannot
fake the
accel_gadget_param_name by passing the param on the query string.
http://codereview.appspot.com/1807042/diff/5001/6004 File java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyHandlerTest.java (right): http://codereview.appspot.com/1807042/diff/5001/6004#newcode84 java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyHandlerTest.java:84: query.append('&' + params[i] + '=' + Utf8UrlCoder.encode(params[i+1])); Going whole-hog! On 2010/07/12 20:36:34, johnfargo wrote:
any reason you chose not to go whole-hog and get rid of the +'s?
http://codereview.appspot.com/1807042/show
