Add some comment to the issue description defining the scope of the
change.


http://codereview.appspot.com/1798042/diff/7001/7
File main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java
(left):

http://codereview.appspot.com/1798042/diff/7001/7#oldcode72
main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java:72: }
Seems you are now removing special code required for handling of
AccelServlet. Can you add few lines pertaining to the scope of the
change to the CL/Issue description.

http://codereview.appspot.com/1798042/diff/7001/8
File
main/java/org/apache/shindig/gadgets/render/GadgetRewritersProvider.java
(left):

http://codereview.appspot.com/1798042/diff/7001/8#oldcode52
main/java/org/apache/shindig/gadgets/render/GadgetRewritersProvider.java:52:
}
Now there will only be one set of rewriters defined for Gadgets. No
special set for Accel Servlet. Where (in GGS ?) do you plan to tailor
this list of rewriters for AccelServlet ?

http://codereview.appspot.com/1798042/diff/7001/9
File main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java
(right):

http://codereview.appspot.com/1798042/diff/7001/9#newcode44
main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java:44:
public void setAccelHandler(AccelHandler accelHandler) {
The public method 'setHandler' name was apt. This Class
(HtmlAccelServlet) already signifies that the handler is Accel specific.

http://codereview.appspot.com/1798042/show

Reply via email to