http://codereview.appspot.com/1770043/diff/13001/14005 File main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java (left):
http://codereview.appspot.com/1770043/diff/13001/14005#oldcode89 main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java:89: } Shouldn't you retain this check as the first statement in the doFetch(). You have the similar check in 'processRequest' http://codereview.appspot.com/1770043/diff/13001/14005 File main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java (right): http://codereview.appspot.com/1770043/diff/13001/14005#newcode105 main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java:105: } Embed this block in a separate method (prepareRequest()) http://codereview.appspot.com/1770043/diff/13001/14008 File test/java/org/apache/shindig/gadgets/servlet/ProxyHandlerTest.java (right): http://codereview.appspot.com/1770043/diff/13001/14008#newcode79 test/java/org/apache/shindig/gadgets/servlet/ProxyHandlerTest.java:79: // expect(request.getHeaders("Host")).andReturn(makeEnumeration(host)); Remove this commented code from the test. http://codereview.appspot.com/1770043/show
