But there could be multiple header values for the same header, like:
Set-Cookie: NAME=value; domain=hello
Set-Cookie: NAME2=value2; domain=buffalo

Set header would just retain the last one (i hope thats why
HttpServletResponse has addHeader and setHeader functions)


Agreed w/ the rationale; I'm just suggesting not changing the API's
semantics out of an abundance of caution. Perhaps it's over-paranoid,
but
I'd prefer to see a new API added that does addHeader rather than
setHeader.
The two could be differentiated on a boolean, w/ both deferring to a
helper
method (basically this one, w/ a new bool applied).

Added a boolean for the same. Not making 2 functions as currently there
is only 1 usage of copyResponseHeadersAndStatusCode.


http://codereview.appspot.com/1822041/show

Reply via email to