Chatted on IM; since this is: A) overridable, and... B) generic-typed "<R>"
This looks good enough to me. Patching and, assuming all goes smoothly, committing. --j On Tue, Jul 20, 2010 at 3:42 PM, <[email protected]> wrote: > > http://codereview.appspot.com/1696052/diff/6001/7001 > File > > java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java > (right): > > http://codereview.appspot.com/1696052/diff/6001/7001#newcode123 > > java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java:123: > CompletionService<R> completionService = new > ExecutorCompletionService<R>(executor); > why not just init this in GadgetHandler at the top level? > > > http://codereview.appspot.com/1696052/show >
