Looks good. Mostly structuring nits; let's sync our CLs and complete
this out.


http://codereview.appspot.com/1862041/diff/9002/15004
File features/src/main/javascript/features/container/container.js
(right):

http://codereview.appspot.com/1862041/diff/9002/15004#newcode204
features/src/main/javascript/features/container/container.js:204: });
why not just have this method call:
this.getGadgetMetadata(gadgetUrls, function(response) { ...stuff... } );

http://codereview.appspot.com/1862041/diff/9002/15004#newcode214
features/src/main/javascript/features/container/container.js:214:
gadgetUrl, callback) {
...thus changing gadgetUrl to gadgetUrls

http://codereview.appspot.com/1862041/diff/9002/15003
File features/src/main/javascript/features/container/gadget_holder.js
(right):

http://codereview.appspot.com/1862041/diff/9002/15003#newcode269
features/src/main/javascript/features/container/gadget_holder.js:269:
uri = this.updateBooleanQueryParam_(uri, 'testmode');
feel free to use shindig.uri once committed :)

http://codereview.appspot.com/1862041/diff/9002/15001
File features/src/main/javascript/features/container/util.js (right):

http://codereview.appspot.com/1862041/diff/9002/15001#newcode140
features/src/main/javascript/features/container/util.js:140: };
shindig.uri ftw

http://codereview.appspot.com/1862041/show

Reply via email to