On 2010/07/26 12:16:10, anupama.dutta wrote:
LGTM.
http://codereview.appspot.com/1811042/diff/37001/38001 File common/conf/shindig.properties (right):
http://codereview.appspot.com/1811042/diff/37001/38001#newcode145 common/conf/shindig.properties:145: # Remap internal server errors
received from
the server being proxied to Rephrase as: Remap "Internal server error"s received from the basicHttpFetcherProxy
server to
"Bad Gateway error"s, so that it is clear to the user that the proxy
server is
the one that threw the exception.
Done.
http://codereview.appspot.com/1811042/diff/37001/38002 File
gadgets/src/main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java
(right):
http://codereview.appspot.com/1811042/diff/37001/38002#newcode107
gadgets/src/main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java:107:
sendResponse(req, results, response); Since we don't have multiple calls to sendResponse, you can remove the
method
and just add back the code here as before.
Done. http://codereview.appspot.com/1811042/show
