---------- Forwarded message ---------- From: <[email protected]> Date: 2010/8/24 Subject: PHP: gadgets.util.sanitizeHtml does not work anymore (issue2011047) To: [email protected] Cc: [email protected]
Reviewers: , Description: Currently the workaround (see https://issues.apache.org/jira/browse/SHINDIG-346?focusedCommentId=12730591&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12730591) to make gadgets.util.sanitizeHtml work in PHP (the Caja Maven dependency is not available and the res:// links in the feature registry do not work therefor) does not work anymore because the linked html-sanitizer.js from the Caja trunk depends on the html4 package now. This dependency is only resolved after building the minified JS files. In order to fix this issue I built the files linked in the feature registry and put them under php/external/resources/. The PHP GadgetFeatureRegistry now resolves all res:// links to be included through a child class of the FilesServlet which then loads the correct file out of the external package. Please review this at http://codereview.appspot.com/2011047/ Affected files: php/config/container.php php/external/resources/com/google/caja/plugin/domita-minified.js php/external/resources/com/google/caja/plugin/html-sanitizer-minified.js php/external/resources/com/google/caja/plugin/valija.out.js php/src/gadgets/GadgetFeatureRegistry.php php/src/gadgets/servlet/ContentFilesServlet.php php/src/gadgets/servlet/FilesServlet.php php/src/gadgets/servlet/ResourcesFilesServlet.php php/test/ShindigAllTests.php php/test/gadgets/FilesServletTest.php
