patch is okay, but we already have code to propagate the default
container values into all other containers.  It's in loadContainers()
See comments for an alternate approach to deal with this issue.



http://codereview.appspot.com/2000043/diff/13001/5003
File
java/common/src/main/java/org/apache/shindig/config/JsonContainerConfig.java
(left):

http://codereview.appspot.com/2000043/diff/13001/5003#oldcode378
java/common/src/main/java/org/apache/shindig/config/JsonContainerConfig.java:378:
// Now that all containers are loaded, we go back through them and merge
This is the code that merges the default params, we should probably
split this into it's own routine (mergeContainers?) and call it after we
modify the container with values from the environment..

http://codereview.appspot.com/2000043/

Reply via email to