On Thu, Aug 26, 2010 at 7:27 PM, <[email protected]> wrote: > > http://codereview.appspot.com/1841045/diff/34001/24002 > File > > java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/ContentTypeCharsetRemoverRewriterTest.java > (right): > > http://codereview.appspot.com/1841045/diff/34001/24002#newcode114 > > java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/ContentTypeCharsetRemoverRewriterTest.java:114: > + "<META Content=\"text/html ; charsett=\'hello\'; hello=world\" " > On 2010/08/26 22:29:45, zhoresh wrote: > >> I don't think this should be recognized as charset, it should not be >> > removed. > > I thought we should retain such attributes because most likely the user > meant charset. > Removing for now. Lets take care of it when we find such an issue.
In the case of accel you probably want to treat bad input the same as a browser does. Maybe you can verify what browser does for such case and correct shindig if needed. > > > http://codereview.appspot.com/1841045/ >
