Hi,

regarding https://issues.apache.org/jira/browse/SHINDIG-1414:
False alarm, after configuring shindig correctly everything worked as expected.

But after reviewing the patches we are currently applying locally, I
found that I overlook one issue, which should probably be fixed in our
2.0.0 release:

---------- Forwarded message ----------
From:  <[email protected]>
Date: 2010/9/2
Subject: PHP: SHINDIG-1144 broke data pipelining and client
compatibility (issue2133042)
To: [email protected]
Cc: [email protected]


Reviewers: ,

Description:
Commit 949663 for issue SHINDIG-1144 broke data pipelining in PHP as
well as compatibility with older client libraries.
In the last weeks we circumvented this locally by reverting this change,
but here is now a clean path for this:

- changed "data" keys to "result" in DataPipelining
- Re-added /social/rpc endpoint which returns old "data" key

Please review this at http://codereview.appspot.com/2133042/

Affected files:
 php/config/container.php
 php/src/gadgets/render/GadgetBaseRenderer.php
 php/src/gadgets/templates/DataPipelining.php
 php/src/social/servlet/CompatibilityJsonRpcServlet.php
 php/src/social/servlet/JsonRpcServlet.php

Reply via email to