Re: Don't return in CajaContentRewriter's finally clause (issue2152046)

[Chirag Shah]

I think I narrowed down the e2e caja test failures.

When the test gadget contains:
        var tests = {
            jsonStringifyTest: function() {}
        }

I get the error: java.lang.AssertionError
        at com.google.caja.lexer.FilePosition.<init>(FilePosition.java:52)
        at 
com.google.caja.lexer.SourceBreaks.toFilePosition(SourceBreaks.java:73)
        at com.google.caja.lexer.FilePosition.span(FilePosition.java:137)
        at com.google.caja.parser.js.ObjProperty.<init>(ObjProperty.java:40)
        at com.google.caja.parser.js.ValueProperty.<init>(ValueProperty.java:17)
        at 
com.google.caja.parser.quasiliteral.DefaultValijaRewriter$42.fire(DefaultValijaRewriter.java:1343)

The test case "works" when the properties inside tests are removed.



On Mon, Sep 13, 2010 at 2:34 PM, Chirag Shah <chiragsh...@gmail.com> wrote:
> This change surfaces several (rather odd) unit test failures in
> EndToEndTest. Do you see the same errors?
>
> java.lang.AssertionError
>        at 
> com.google.caja.lexer.FilePosition.&lt;init&gt;(FilePosition.java:52)
>        at 
> com.google.caja.lexer.SourceBreaks.toFilePosition(SourceBreaks.java:73)
>        at com.google.caja.lexer.FilePosition.span(FilePosition.java:137)
>        at 
> com.google.caja.parser.js.ObjProperty.&lt;init&gt;(ObjProperty.java:40)
>        at 
> com.google.caja.parser.js.ValueProperty.&lt;init&gt;(ValueProperty.java:17)
>
> On Sun, Sep 12, 2010 at 10:24 PM,  <jas...@gmail.com> wrote:
>> Absolutely LGTM.
>>
>> http://codereview.appspot.com/2152046/
>>
>