Okay, big cleanup patch landed. If you need to merge your patch you might want to run things through fixjsstyle script to harmonize.
On Fri, Sep 10, 2010 at 5:10 AM, Gagandeep Singh <[email protected]>wrote: > The patch looks good. A script to split all the files into multiple > codereviews could be helpful here. > > Thanks > Gagan > > > > > On Fri, Sep 10, 2010 at 4:33 PM, Paul Lindner <[email protected]> > wrote: > > > A while back I had started cleaning up the javascript code base to use > > improved JsDoc annotations. > > > > Recently the Closure Linter was released: > > > > http://code.google.com/closure/utilities/ > > > > I'd like to propose that we run all of the javascript code through > > fixjsstyle. A patch of this size causes codereview to fail. If you're > > curious to see what types of changes are made you can see the diff here: > > http://www.inuus.com/tmp/linter.diff > > > > -- > > Paul Lindner -- [email protected] -- linkedin.com/in/plindner > > > -- Paul Lindner -- [email protected] -- linkedin.com/in/plindner
