Thanks Paul. On 4 October 2010 21:39, Paul Lindner <[email protected]> wrote:
> k thx, ship it! > > > On Mon, Oct 4, 2010 at 8:49 AM, Gagandeep singh <[email protected]> > wrote: > > > http://codereview.appspot.com/2085042/diff/27001/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/ConcatVisitorTest.java > > has nice tests for conditional and non conditional comments. > > > > On Mon, Oct 4, 2010 at 9:05 PM, <[email protected]> wrote: > >> > >> lgtm, if you could add a follow-on test for conditional comments I'd > >> appreciate it. > >> > >> http://codereview.appspot.com/2085042/ > > > > > > > > -- > Paul Lindner -- [email protected] -- linkedin.com/in/plindner >
