I think it's a good idea to consider targeting java 1.6 source-level compatibility and java 1.5 runtime level compatibility.
Anyone else opposed? On Mon, Oct 18, 2010 at 8:04 PM, Gagandeep singh <[email protected]>wrote: > Sorry this cl broke the build because of @Override annotation > on ImageAttributeRewriter.revisit(). > Committed a fix as r1024097. > > General doubt: Can we move shindig to java1.6 ? I think this problem occurs > because of java 1.5. > Alternately, is there an easy way of pointing maven to java 1.5 > installation > so that > # mvn -e clean install > > catches such errors ? > > Thanks > Gagan > > On Tue, Oct 19, 2010 at 8:00 AM, Apache Hudson Server < > [email protected]> wrote: > > > See < > > > https://hudson.apache.org/hudson/job/Shindig/org.apache.shindig$shindig-gadgets/1924/changes > > > > > > > Changes: > > > > [gagan] Patch by satya3656 | Issue 2044045: Adding ImageAttributeRewriter > > that adds the height and width attributes if they are not specified. | > > http://codereview.appspot.com/2044045/ > > > > ------------------------------------------ > > [INFO] > > ------------------------------------------------------------------------ > > [INFO] Building Apache Shindig Gadget Renderer > > [INFO] task-segment: [clean, install] > > [INFO] > > ------------------------------------------------------------------------ > > [INFO] [clean:clean {execution: default-clean}] > > [INFO] Deleting file set: < > > > https://hudson.apache.org/hudson/job/Shindig/org.apache.shindig$shindig-gadgets/ws/target > > > > (included: [**], excluded: []) > > [TASKS] Scanning folder '< > > > https://hudson.apache.org/hudson/job/Shindig/org.apache.shindig$shindig-gadgets/ws/src/main/java > '> > > for tasks ... > > [TASKS] Found 0. > > [TASKS] Scanning folder '< > > > https://hudson.apache.org/hudson/job/Shindig/org.apache.shindig$shindig-gadgets/ws/src/test/java > '> > > for tasks ... > > [TASKS] Found 0. > > [TASKS] Scanning folder '< > > > https://hudson.apache.org/hudson/job/Shindig/org.apache.shindig$shindig-gadgets/ws/../../config > '> > > for tasks ... > > [TASKS] Found 0. > > [TASKS] Scanning folder '< > > > https://hudson.apache.org/hudson/job/Shindig/org.apache.shindig$shindig-gadgets/ws/src/main/resources > '> > > for tasks ... > > [TASKS] Found 0. > > [TASKS] Scanning folder '< > > > https://hudson.apache.org/hudson/job/Shindig/org.apache.shindig$shindig-gadgets/ws/../../content > '> > > for tasks ... > > [TASKS] Found 0. > > [TASKS] Scanning folder '< > > > https://hudson.apache.org/hudson/job/Shindig/org.apache.shindig$shindig-gadgets/ws/src/test/resources > '> > > for tasks ... > > [TASKS] Found 0. > > [INFO] [enforcer:enforce {execution: enforce-java}] > > [TASKS] Skipping maven reporter: there is already a result available. > > [INFO] [remote-resources:process {execution: default}] > > [INFO] [resources:resources {execution: default-resources}] > > [INFO] Using 'UTF-8' encoding to copy filtered resources. > > [TASKS] Skipping maven reporter: there is already a result > available.[INFO] > > Copying 2 resources to config > > > > [INFO] Copying 0 resource > > [INFO] Copying 2 resources to files > > [INFO] Copying 3 resources > > [INFO] [compiler:compile {execution: default-compile}] > > [TASKS] Skipping maven reporter: there is already a result available. > > [INFO] Compiling 251 source files to < > > > https://hudson.apache.org/hudson/job/Shindig/org.apache.shindig$shindig-gadgets/ws/target/classes > > > > > [INFO] ------------------------------------------------------------- > > [WARNING] COMPILATION WARNING : > > [INFO] ------------------------------------------------------------- > > [WARNING] < > > > https://hudson.apache.org/hudson/job/Shindig/org.apache.shindig$shindig-gadgets/ws/src/main/java/org/apache/shindig/gadgets/parse/caja/VanillaCajaHtmlSerializer.java > >:[41,21] > > [deprecation] render(org.w3c.dom.Node,boolean) in > > com.google.caja.parser.html.Nodes has been deprecated > > [WARNING] < > > > https://hudson.apache.org/hudson/job/Shindig/org.apache.shindig$shindig-gadgets/ws/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java > >:[39,16] > > [deprecation] render(org.w3c.dom.Node,boolean) in > > com.google.caja.parser.html.Nodes has been deprecated > > [INFO] 2 warnings > > [INFO] ------------------------------------------------------------- > > [INFO] ------------------------------------------------------------- > > [ERROR] COMPILATION ERROR : > > [INFO] ------------------------------------------------------------- > > [ERROR] < > > > https://hudson.apache.org/hudson/job/Shindig/org.apache.shindig$shindig-gadgets/ws/src/main/java/org/apache/shindig/gadgets/rewrite/ImageAttributeRewriter.java > >:[98,5] > > method does not override a method from its superclass > > [INFO] 1 error > > [INFO] ------------------------------------------------------------- > > [TASKS] Skipping maven reporter: there is already a result available. > > [HUDSON] Archiving < > > > https://hudson.apache.org/hudson/job/Shindig/org.apache.shindig$shindig-gadgets/ws/pom.xml > > > > to > > > /home/hudson/hudson/jobs/Shindig/modules/org.apache.shindig$shindig-gadgets/builds/2010-10-19_02-28-31/archive/org.apache.shindig/shindig-gadgets/3.0.0-SNAPSHOT/pom.xml > > [INFO] > > ------------------------------------------------------------------------ > > [ERROR] BUILD FAILURE > > [INFO] > > ------------------------------------------------------------------------ > > [INFO] Compilation failure > > < > > > https://hudson.apache.org/hudson/job/Shindig/org.apache.shindig$shindig-gadgets/ws/src/main/java/org/apache/shindig/gadgets/rewrite/ImageAttributeRewriter.java > >:[98,5] > > method does not override a method from its superclass > > > > [INFO] > > ------------------------------------------------------------------------ > > [INFO] For more information, run Maven with the -e switch > > [INFO] > > ------------------------------------------------------------------------ > > [INFO] Total time: 1 minute 59 seconds > > [INFO] Finished at: Tue Oct 19 02:30:44 UTC 2010 > > [INFO] Final Memory: 59M/268M > > [INFO] > > ------------------------------------------------------------------------ > > > > > -- Paul Lindner -- [email protected] -- linkedin.com/in/plindner
