LGTM

On Wed, Nov 17, 2010 at 12:32 PM, Gagandeep singh <[email protected]>wrote:

> Reviewers: [email protected], fargo <http://<[email protected]>>,
> zhoresh <[email protected]>
>
> Description:
>
> This cl:
> 1) Makes RewritePath class public (I missed it
> inhttp://codereview.appspot.com/2058042/)
> 2) Makes some of the helper methods of RewriteModule protected so other
> classes
> that extend RewriteModule can reuse these.
>
> Please review this at http://codereview.appspot.com/3175041/
>
> Affected files:
>  M
>
> java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/RewriteModule.java
>  M
>
> java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/RewritePath.java
>
> Thanks
> Gagan
>

Reply via email to