Committed as r1036645. On Thu, Nov 18, 2010 at 12:48 PM, John Hjelmstad <[email protected]>wrote:
> Sounds great, LGTM still. I'll commit. > > > On Thu, Nov 18, 2010 at 12:38 PM, Jacobo Tarrio <[email protected]> wrote: > >> We did, but it was wrong. The code I had added removed the property if it >> was null after merging, but on the next transaction it would go through the >> properties again, not find the null value, and therefore inherit. >> >> Now it just copies the null value, so it persists when there are several >> transactions. The getXxxx functions don't distinguish between null values >> and non-existing values, so everything should work the same (except >> getProperties, which will return properties with null values). >> >> >> On Thu, Nov 18, 2010 at 11:35 AM, <[email protected]> wrote: >> >>> ...though, didn't we add the line in BasicContainerConfig.java >>> specifically to allow nullification to work? >>> >>> >>> On 2010/11/18 19:35:28, johnfargo wrote: >>> >>>> LGTM >>>> On 2010/11/18 03:38:42, jtarrio wrote: >>>> >>> >>> >>> >>> http://codereview.appspot.com/3194041/ >>> >> >> >> >> -- >> Jacobo TarrĂo | http://jacobo.tarrio.org/ >> > >
