Well domita-minified and valija.out.js are both referenced as resources
("res://"). The other two are already in the
features/src/main/javascript/features/caja directory. Which operation are
you seeing break?--j On Tue, Dec 14, 2010 at 4:51 PM, Henry Saputra <[email protected]>wrote: > The caja feature.xml file contains this: > > <feature> > <name>caja</name> > <gadget> > <script src="res://com/google/caja/plugin/domita-minified.js"/> > <script src="caja.js"/> > <script src="res://com/google/caja/plugin/valija.out.js"/> > <script src="taming.js"/> > </gadget> > </feature> > > I dont think Java module packages these JavaScript as Java resource. > Should I just add them to java/gadgets/src/main/resources/ path? > > - Henry > > On Tue, Dec 14, 2010 at 12:18 PM, John Hjelmstad <[email protected]> wrote: > > Hmm... Naive question, how does this affect the PHP build? My change > removed > > Java functionality which swallowed an IOException when loading a > nonexistent > > resource. > > > > The reason this broke the integration test is that the JS loader (in > Java) > > attempts to load "<resource>.js" as well as "<resource>.opt.js". For all > > built resources, these two files exist. For res://-style resources loaded > > from JARs (such as domita), the *.opt.js version isn't present. That's > OK; > > downstream code will treat them as equivalent in this case. > > > > I missed it the first go-around since code further upstream was still > > catching an IOException (for another reason). > > > > --j > > > > On Tue, Dec 14, 2010 at 12:14 PM, Henry Saputra <[email protected] > >wrote: > > > >> But the failed tests looks like expose missing resources for Java > project: > >> > >> com/google/caja/plugin/domita-minified.js > >> com/google/caja/plugin/valija.out.js > >> com/google/caja/plugin/html-sanitizer-minified.js > >> > >> The PHP version has these checked in to the external directory. > >> > >> Or maybe I am missing something? > >> > >> - Henry > >> > >> On Tue, Dec 14, 2010 at 12:02 PM, John Hjelmstad <[email protected]> > wrote: > >> > Yep, it was. Committed r1049239. Apologies for the trouble! > >> > > >> > On Tue, Dec 14, 2010 at 11:47 AM, John Hjelmstad <[email protected]> > >> wrote: > >> > > >> >> I believe it's my fix. > >> >> > >> >> On Tue, Dec 14, 2010 at 11:33 AM, Eric Woods <[email protected]> > >> wrote: > >> >> > >> >>> Hi, > >> >>> > >> >>> The Shindig build seems to be failing: > >> >>> https://hudson.apache.org/hudson/job/Shindig/2049/. It's important > >> that > >> >>> we get this back up and running as soon as possible. Does anyone > know > >> when > >> >>> a fix is expected? > >> >>> > >> >>> Thanks, > >> >>> Eric W. > >> >> > >> >> > >> >> > >> > > >> > >> > >> > >> -- > >> Thanks, > >> Henry > >> > > > > > > -- > Thanks, > Henry >
