Thanks for the info Henry. Maybe we should update the instructions then if they have changed.
I can forward the code review email I got to the dev list that's not a problem, just wanted to make sure I understood the process before doing that. I also created a JIRA which is here https://issues.apache.org/jira/browse/SHINDIG-1484. As a side note, how do I assign the JIRA to me? It wasn't obvious to me how to do that. Thanks for the info. -Ryan Email: [email protected] Phone: 978-899-3041 developerWorks Profile From: Henry Saputra <[email protected]> To: [email protected] Date: 12/21/2010 01:31 PM Subject: Re: Creating and submitting a patch Hi Ryan, I remember there in an issue where the dev-remailer filter the emails from codereview =( Another good practice is to create a JIRA case at https://issues.apache.org/jira/browse/SHINDIG which will send email to dev@ list. Then you can add codereview url in the description as well as attach the patch file. Creating JIRA case will allow use to track and prioritize issues in Shindig and also records your contribution to Shindig. Thanks, Henry On Tue, Dec 21, 2010 at 6:13 AM, Ryan J Baxter <[email protected]> wrote: > Hi All, > > I was following the instructions on this page for creating and submitting > a patch to Shindig, http://shindig.apache.org/community/index.html. I > have a question about step 7. I created an issue at > codereview.appspot.com, added [email protected] as a > reviewer, and uploaded my patch. However, I did not see an email go out > to the mailing list notifying everyone. From what I have seen for other > fixes, there seems to be an email that gets sent out to everyone. Am I > doing something wrong? > > http://codereview.appspot.com/3811041/ > > -Ryan > > Email: [email protected] > Phone: 978-899-3041 > developerWorks Profile > > -- Thanks, Henry
