Hi Maxwell, Not sure I understand what you are saying. What property in container.js are you referring to?
-Ryan Email: [email protected] Phone: 978-899-3041 developerWorks Profile From: Maxwell <[email protected]> To: [email protected] Date: 12/21/2010 08:20 PM Subject: Re: Fw: Fix For SHINDIG-1484 (issue3811041) Hey Ryan, In the case you set the serverBase, you could get the value from container.js, will help people that need to change context to a non-root. Maxwell On Tue, Dec 21, 2010 at 11:02 PM, Ryan J Baxter <[email protected]> wrote: > Hi All, > > Could someone please code review this fix for me. Its a very small > change, so shouldn't take to much effort. Thanks. > > -Ryan > > Email: [email protected] > Phone: 978-899-3041 > developerWorks Profile > ----- Forwarded by Ryan J Baxter/Westford/IBM on 12/21/2010 08:01 PM ----- > > From: [email protected] > To: [email protected] > Cc: Ryan J Baxter/Westford/i...@lotus, [email protected] > Date: 12/20/2010 09:29 PM > Subject: Fix For SHINDIG-1484 (issue3811041) > > > > Reviewers: dev-remailer_shindig.apache.org, > > Description: > When you extend shindig.BaseIfrGadget in your own container the above > code makes it difficult to override serverBase_. > https://issues.apache.org/jira/browse/SHINDIG-1484 > > Please review this at http://codereview.appspot.com/3811041/ > > Affected files: > > > features/src/main/javascript/features/shindig.container/shindig-container.js > > > ### Eclipse Workspace Patch 1.0 > #P shindig-project > Index: > > features/src/main/javascript/features/shindig.container/shindig-container.js > =================================================================== > --- > > features/src/main/javascript/features/shindig.container/shindig-container.js > > (revision 1050262) > +++ > > features/src/main/javascript/features/shindig.container/shindig-container.js > > (working copy) > @@ -479,7 +479,9 @@ > > shindig.BaseIfrGadget = function(opt_params) { > shindig.Gadget.call(this, opt_params); > - this.serverBase_ = '/gadgets/'; // default gadget server > + if(!this.serverBase_){ > + this.serverBase_ = '/gadgets/'; // default gadget > server > + } > this.queryIfrGadgetType_(); > }; > > > > > >
