Reviewers: dev-remailer_shindig.apache.org, dev_shindig.apache.org, gagan.goku,

Description:
Small fix to ImageResizeRewriter to make it backward compatible with
java 1.5.

Please review this at http://codereview.appspot.com/3798045/

Affected files:
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ImageResizeRewriter.java


Index: java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ImageResizeRewriter.java
===================================================================
--- java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ImageResizeRewriter.java (revision 1053308) +++ java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ImageResizeRewriter.java (working copy)
@@ -84,7 +84,7 @@
     }

     private boolean isEmpty(Element element, String attribute) {
-      return element.getAttribute(attribute).isEmpty();
+      return "".equals(element.getAttribute(attribute));
     }

public boolean revisit(Gadget gadget, List<Node> nodes) throws RewritingException {
@@ -174,7 +174,7 @@
       }

       Integer value = null;
-      if (!integerPrefix.isEmpty()) {
+      if (!"".equals(integerPrefix)) {
         try {
           value = NumberUtils.createInteger(integerPrefix);
         } catch (NumberFormatException e) {


Reply via email to