I think that is just for default container, when you do not pass a container parameter in urls, if you want to use a different configuration, and do not want to change the default container in property, you can pass a different container parameter in the urls.
But, i'm still think create a custom-properties-module is the best option in this case. On Wed, Jan 26, 2011 at 6:28 AM, franck tankoua <[email protected]> wrote: > Hi All, > The comment is sure outdated. > I also think there may be a design thinking to put there. When you offer a > possibility to configure something in your web.xml normally you want to > stay > as orthogonal as possible. > This means I do not see the point of providing the container.js through the > web.xml while modifying manually the shindig.properties. I think if you can > change the properties why not changing the container.js, since at the end > you will modify the final shindig-common jar file. > > If we want a user to change the container.js in web.xml, there should be > the > same kind of mechanism for the shindig.properties as well. > > Let me know if I misunderstood something. > > Thanks > > On Wed, Jan 26, 2011 at 2:50 AM, Henry Saputra <[email protected] > >wrote: > > > Hi Gagan, > > > > But the key is that we need to modify shindig.properties file to add/ > > override the default container file, rather than simply change the > > web.xml file to include new container config file . > > > > - Henry > > > > On Tue, Jan 25, 2011 at 7:59 PM, Gagandeep singh <[email protected]> > > wrote: > > > Does this work: ? > > > > > > Adding your container config to > > > view-source: > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/pom.xm< > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/pom.xml> > > > as > > > an include (like the way container.js is included): > > > <include>container.js</include> > > > <include>my_container.js</include> > > > > > > And giving its path in shindig.properties file: > > > # Location of container configurations (comma separated) > > > shindig.containers.default=res://containers/default/container.js, > > > res://containers/default/my_container.js > > > > > > If so, we might want to change the comment to something like this. > > > > > > On Wed, Jan 26, 2011 at 2:40 AM, Henry Saputra < > [email protected] > > >wrote: > > > > > >> Yes, i know about using custom property module to change the path to > > >> default container file. > > >> > > >> I was talking about the comment in the container.js file which give > > >> impression that you can simply specify custom container file in the > > >> web.xml file. > > >> > > >> Probably need to rewrite the comment in the config/container.js file. > > >> > > > Yes, :( > > > This comment confused me a lot when i wanted to add accel config, and i > > > couldnt make head or tail out of what was happening. > > > Luckily just adding accel container to default container.js worked :) > > > > > > > > >> Henry > > >> > > >> On Tuesday, January 25, 2011, Stanton Sievers <[email protected]> > > wrote: > > >> > Hi Henry, > > >> > > > >> > There was recent discussion on this topic on this mailing list. > > Here's > > >> > the mail archive for it: > > >> > http://www.mail-archive.com/[email protected]/msg03025.html > > >> > > > >> > Hope that helps. > > >> > -Stanton > > >> > > > >> > > > >> > > > >> > From: Henry Saputra <[email protected]> > > >> > To: [email protected] > > >> > Date: 01/25/2011 15:48 > > >> > Subject: Question about changing the default container.js > file > > >> > > > >> > > > >> > > > >> > Hi All, > > >> > > > >> > I was looking at the comment section for config/container.js and > found > > >> > this: > > >> > > > >> > // Default container configuration. To change the configuration, you > > >> > have two options: > > >> > // > > >> > // A. If you run the Java server: Create your own "myContainer.js" > > file > > >> > and > > >> > // modify the value in web.xml. > > >> > // > > >> > > > >> > AS far as I know the default configuration files is set in the > > >> > shindig.properties file so it could not be changed via web.xml as > the > > >> > comment has stated. > > >> > > > >> > Does anyone know about how to modify the web.xml to add new > container > > >> > file? > > >> > > > >> > -- > > >> > Thanks, > > >> > Henry > > >> > > > >> > > > >> > > > >> > > > >> > > >> -- > > >> Thanks, > > >> > > >> Henry > > >> > > > > > > > > > > > -- > > Thanks, > > Henry > > > > > > -- > Franck >
