snapshot
http://codereview.appspot.com/4303043/diff/1/features/src/main/javascript/features/caja/taming.js File features/src/main/javascript/features/caja/taming.js (right): http://codereview.appspot.com/4303043/diff/1/features/src/main/javascript/features/caja/taming.js#newcode65 features/src/main/javascript/features/caja/taming.js:65: ___.markFunc(schema[0][schema[1]], schema[1]); On 2011/03/22 17:49:54, ihab.awad wrote:
Use markTameAsFunction() not markFunc(). Throughout. But ok as-is
given your
clarification that these are not yet being used and will be replaced
wholesale
asap in favor of a caja.js-based solution.
Done. http://codereview.appspot.com/4303043/diff/1/features/src/main/javascript/features/caja/taming.js#newcode100 features/src/main/javascript/features/caja/taming.js:100: imports.window = imports.window || {}; On 2011/03/23 01:52:35, johnfargo wrote:
all this JS will soon be subjected to Closure's property obfuscation.
I assume
the key names here are important/should not be obfuscated. True? If
so, I'd
recommend ['window'] et al.
Done. http://codereview.appspot.com/4303043/diff/1/features/src/main/javascript/features/caja/taming.js#newcode105 features/src/main/javascript/features/caja/taming.js:105: imports = imports.window; On 2011/03/22 07:48:24, felix8a wrote:
it wasn't immediately obvious to me why imports and window are
constructed in
this weird way. but all this is going to be replaced soon-ish anyway,
right? Done. http://codereview.appspot.com/4303043/
