I have uploaded the patch to new CR entry with correct SVN repo: http://codereview.appspot.com/4423064/
- Henry On Thu, Apr 21, 2011 at 1:34 PM, Han Nguyen <[email protected]> wrote: > Li is out of office this week, she's returning next Monday. Is there a way > to add additional editor on code review going forward? > Han > > > > From: Henry Saputra <[email protected]> > To: [email protected] > Date: 04/21/2011 02:30 PM > Subject: Re: [jira] [Commented] (SHINDIG-1525) Enable shindig to > run on non-ROOT context path > > > > Could you change the repo svn from > http://svn.apache.org/repos/asf/incubator/shindig/trunk/ to > http://svn.apache.org/repos/asf/shindig/trunk/ > > - Henry > > On Fri, Apr 15, 2011 at 3:11 PM, li xu (JIRA) <[email protected]> wrote: >> >> [ > https://issues.apache.org/jira/browse/SHINDIG-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020452#comment-13020452 > ] >> >> li xu commented on SHINDIG-1525: >> -------------------------------- >> >> yes, it's uploaded here: http://codereview.appspot.com/4430047/ >> thanks. >> >>> Enable shindig to run on non-ROOT context path >>> ---------------------------------------------- >>> >>> Key: SHINDIG-1525 >>> URL: https://issues.apache.org/jira/browse/SHINDIG-1525 >>> Project: Shindig >>> Issue Type: Improvement >>> Components: Java, Javascript >>> Affects Versions: 3.0.0 >>> Reporter: li xu >>> Labels: patch >>> Fix For: 3.0.0 >>> >>> Attachments: contextRoot415.patch >>> >>> Original Estimate: 336h >>> Remaining Estimate: 336h >>> >>> Shindig is running on ROOT only today. This patch enables Shindig to > run on dynamic context root path without any hardcoded modification to the > code. >>> Test Case: >>> 1. deploy shindig.war with a context root path eg "test" >>> 2. test common container with this url: >>> > http://localhost:8080/test/samplecontainer/examples/commoncontainer/index.jsp > >>> Thanks Mark Nesbitt for the original idea of the patch. >> >> -- >> This message is automatically generated by JIRA. >> For more information on JIRA, see: > http://www.atlassian.com/software/jira >> > > > > -- > Thanks, > Henry > > > -- Thanks, Henry
