Igor, thanks for the patch! For ease review please use the codereview tool ( http://codereview.appspot.com/) to upload a patch next time. Also for completion it nice to have the code change with its test in one patch (otherwise we forget...)
I reviewed your code, the one comment I have is that I think you update the feature value in place, I think you should actually create a new Feature with the substitution instead. Basically the perf might be cached, and be required by different localization, and you want to keep the original form in the original perf so it can be substituted as needed. Thanks Ziv On Thu, Apr 28, 2011 at 12:19 PM, Igor Belakovskiy (JIRA) <[email protected]>wrote: > > [ > https://issues.apache.org/jira/browse/SHINDIG-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel] > > Igor Belakovskiy updated SHINDIG-1523: > -------------------------------------- > > Labels: Enhancement (was: Enhancement Feature) > Description: > Allow the localization of feature parameters. This allows us to provide > parameters that can be localized when the gadget definition is processed. In > the example below, __MSG_mytest__ will get replaced with "Search" from the > bundle. The localized XML inside the CDATA can then be consumed by the > container. > > Sample gadget definition: > > <?xml version="1.0" encoding="UTF-8" ?> > <Module> > <ModulePrefs title="Hello" description="Message "> > <Locale messages="messages.xml"/> > > <Require feature="dynamic-height" /> > <Require feature="setprefs" /> > <Optional feature="opensearch"> > <Param name="opensearch-description"><![CDATA[<OpenSearchDescription > xmlns="http://a9.com/-/spec/opensearch/1.1/";> > <ShortName>__MSG_mytest__</ShortName> > <Description>Realtime Twitter Search</Description> > <Url type="application/atom+xml" method="get" template=" > http://search.twitter.com/search.atom?q={searchTerms}"/> > <Image width="16" height="16">http://search.twitter.com/favicon.png > </Image> > <InputEncoding>UTF-8</InputEncoding> > <SearchForm>http://search.twitter.com/</SearchForm> > > </OpenSearchDescription>]]></Param> > </Optional> > > </ModulePrefs> > > <Content type="url" href="http://www.example.com/search/index.html"; /> > </Module> > > > Sample message bundle: > <?xml version="1.0" encoding="UTF-8"?> > <messagebundle> > <msg name="mytest"> > Search > </msg> > </messagebundle> > > was: > Allow the localization of feature parameters. This allows us to provide > parameters that can be localized when the gadget definition is processed. In > the example below, __MSG_mytest__ will get replaced with "Search" from the > bundle. The localized XML inside the CDATA can then be consumed by the > container. > > > <?xml version="1.0" encoding="UTF-8" ?> > <Module> > <ModulePrefs title="Hello" description="Message "> > <Locale messages="messages.xml"/> > > <Require feature="dynamic-height" /> > <Require feature="setprefs" /> > <Optional feature="opensearch"> > <Param name="opensearch-description"><![CDATA[<OpenSearchDescription > xmlns="http://a9.com/-/spec/opensearch/1.1/";> > <ShortName>__MSG_mytest__</ShortName> > <Description>Realtime Twitter Search</Description> > <Url type="application/atom+xml" method="get" template=" > http://search.twitter.com/search.atom?q={searchTerms}"/> > <Image width="16" height="16">http://search.twitter.com/favicon.png > </Image> > <InputEncoding>UTF-8</InputEncoding> > <SearchForm>http://search.twitter.com/</SearchForm> > > </OpenSearchDescription>]]></Param> > </Optional> > > </ModulePrefs> > > <Content type="url" href="http://www.example.com/search/index.html"; /> > </Module> > > <?xml version="1.0" encoding="UTF-8"?> > <messagebundle> > > <msg name="mytest"> > Search > </msg> > > > </messagebundle> > > > > allow localizable params in feature specification > > ------------------------------------------------- > > > > Key: SHINDIG-1523 > > URL: https://issues.apache.org/jira/browse/SHINDIG-1523 > > Project: Shindig > > Issue Type: Improvement > > Components: Java > > Affects Versions: 2.0.0, 2.0.2, 3.0.0 > > Environment: All > > Reporter: Igor Belakovskiy > > Labels: Enhancement > > Fix For: 2.0.0, 2.0.2, 3.0.0 > > > > Attachments: featureparams04282011.txt > > > > Original Estimate: 0h > > Remaining Estimate: 0h > > > > Allow the localization of feature parameters. This allows us to provide > parameters that can be localized when the gadget definition is processed. In > the example below, __MSG_mytest__ will get replaced with "Search" from the > bundle. The localized XML inside the CDATA can then be consumed by the > container. > > Sample gadget definition: > > <?xml version="1.0" encoding="UTF-8" ?> > > <Module> > > <ModulePrefs title="Hello" description="Message "> > > <Locale messages="messages.xml"/> > > > > <Require feature="dynamic-height" /> > > <Require feature="setprefs" /> > > <Optional feature="opensearch"> > > <Param name="opensearch-description"><![CDATA[<OpenSearchDescription > xmlns="http://a9.com/-/spec/opensearch/1.1/";> > > <ShortName>__MSG_mytest__</ShortName> > > <Description>Realtime Twitter Search</Description> > > <Url type="application/atom+xml" method="get" template=" > http://search.twitter.com/search.atom?q={searchTerms}"/> > > <Image width="16" height="16">http://search.twitter.com/favicon.png > </Image> > > <InputEncoding>UTF-8</InputEncoding> > > <SearchForm>http://search.twitter.com/</SearchForm> > > </OpenSearchDescription>]]></Param> > > </Optional> > > </ModulePrefs> > > <Content type="url" href="http://www.example.com/search/index.html"; /> > > </Module> > > Sample message bundle: > > <?xml version="1.0" encoding="UTF-8"?> > > <messagebundle> > > <msg name="mytest"> > > Search > > </msg> > > </messagebundle> > > -- > This message is automatically generated by JIRA. > For more information on JIRA, see: http://www.atlassian.com/software/jira >
