-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/747/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
1. osapi dynamically defined methods are now tamed correctly.
2. the browser-native gadgets.json.stringify had a bug in the replacer
function. for keys that should be ignored, it was returning null instead of
undefined, so a value like {a___:3} was being stringified as {'a___':null}
rather than {}
3. features/alltests.js didn't work, because it was out of sync with reality.
I updated it to match the jsunit rule in pom.xml.
Diffs
-----
/trunk/features/src/main/javascript/features/caja/feature.xml 1103952
/trunk/features/src/main/javascript/features/caja/taming.js 1103952
/trunk/features/src/main/javascript/features/core.json/json-jsimpl.js 1103952
/trunk/features/src/main/javascript/features/core.json/json-native.js 1103952
/trunk/features/src/main/javascript/features/opensocial-reference/taming.js
1103952
/trunk/features/src/main/javascript/features/osapi.base/feature.xml 1103952
/trunk/features/src/main/javascript/features/osapi.base/osapi.js 1103952
/trunk/features/src/main/javascript/features/osapi.base/taming.js 1103952
/trunk/features/src/test/javascript/features/alltests.js 1103952
/trunk/features/src/test/javascript/features/mocks/env.js 1103952
Diff: https://reviews.apache.org/r/747/diff
Testing
-------
"mvn test" passes
sample osapi gadget loaded in sample container works (mostly).
Thanks,
felix
