-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/751/#review684
-----------------------------------------------------------

Ship it!


Looks good to me.  But then... I wrote it :)

- Eric


On 2011-05-17 00:36:52, Paul Lindner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/751/
> -----------------------------------------------------------
> 
> (Updated 2011-05-17 00:36:52)
> 
> 
> Review request for shindig.
> 
> 
> Summary
> -------
> 
> dup of http://codereview.appspot.com/3988041/
> 
> 
> Support:
> - Activity Streams 1.0 data model
> - JSON/XML/ATOM serialization support
> - Test fixtures
> 
> 
> This addresses bug SHINDIG-1536.
>     https://issues.apache.org/jira/browse/SHINDIG-1536
> 
> 
> Diffs
> -----
> 
>   trunk/config/container.js 1102330 
>   
> trunk/content/samplecontainer/examples/ActivityStreams/ActivityStreamsRender.js
>  1102330 
>   trunk/content/samplecontainer/examples/ActivityStreams/OpenSocialWrapper.js 
> 1102330 
>   trunk/content/sampledata/canonicaldb.json 1102330 
>   
> trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/ActivityEntryImpl.java
>  1102330 
>   
> trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/ActivityObjectImpl.java
>  1102330 
>   
> trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/ExtensionImpl.java
>  PRE-CREATION 
>   
> trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/OpenSocialImpl.java
>  1102330 
>   
> trunk/java/social-api/src/main/java/org/apache/shindig/social/core/util/atom/AtomEntry.java
>  1102330 
>   
> trunk/java/social-api/src/main/java/org/apache/shindig/social/core/util/xstream/XStream081Configuration.java
>  1102330 
>   
> trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/ActivityEntry.java
>  1102330 
>   
> trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/ActivityObject.java
>  1102330 
>   
> trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/Extension.java
>  PRE-CREATION 
>   
> trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/MediaLink.java
>  1102330 
>   
> trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/OpenSocial.java
>  1102330 
>   
> trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/ActivityStreamService.java
>  1102330 
>   
> trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java
>  1102330 
>   
> trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulAtomActivityEntryTest.java
>  1102330 
>   
> trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonActivityEntryTest.java
>  1102330 
>   
> trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulXmlActivityEntryTest.java
>  1102330 
>   
> trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryAtomId.xml
>  1102330 
>   
> trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryAtomIds.xml
>  1102330 
>   
> trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonCreated.json
>  1102330 
>   
> trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonDelete.json
>  1102330 
>   
> trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json
>  1102330 
>   
> trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonId.json
>  1102330 
>   
> trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json
>  1102330 
>   
> trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonUpdated.json
>  1102330 
>   
> trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlId.xml
>  1102330 
>   
> trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlIds.xml
>  1102330 
>   
> trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityStreamsSupportedFields.json
>  1102330 
>   
> trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/ActivityStreamHandlerTest.java
>  1102330 
>   
> trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java
>  1102330 
> 
> Diff: https://reviews.apache.org/r/751/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Paul
> 
>

Reply via email to