LGTM On Fri, May 27, 2011 at 2:55 AM, Felix Lee <[email protected]> wrote:
> > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/793/ > ----------------------------------------------------------- > > Review request for shindig. > > > Summary > ------- > > Currently, when Caja is enabled, the data passed to an osapi callback is > read-only. The SocialHelloWorld demo tries to push a new element into that > read-only data, which fails. > > I might be able to modify the Caja taming to return writeable data, but I > have to think through the implications of that. > > In the meantime, this patch modifies the demo to make a copy of the > read-only data. > > > Diffs > ----- > > /trunk/content/samplecontainer/examples/SocialHelloWorld.xml 1128124 > > Diff: https://reviews.apache.org/r/793/diff > > > Testing > ------- > > Demo works in sample container with Caja enabled, on Chrome. > > > Thanks, > > Felix > >
