----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/854/#review764 -----------------------------------------------------------
Ship it! - Jasvir On 2011-06-03 21:23:35, Felix Lee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/854/ > ----------------------------------------------------------- > > (Updated 2011-06-03 21:23:35) > > > Review request for shindig. > > > Summary > ------- > > Shindig-Caja's URI policy rewrites most URIs to use a container proxy. This > proxy only works for absolute URIs, which I think is fine, since it doesn't > look to me like there's a consistent interpretation for relative URIs in a > gadget, so I don't think any real gadgets will be using relative URIs. > > However, some of the sample gadgets use relative URIs for images, which works > because the sample gadgets and images are embedded in the web-app. But when > these sample gadgets are rendered with Caja enabled, the images are broken, > because the proxy request gets a relative URI that the proxy can't resolve. > While this is basically working as expected, the broken images look like > something is broken, and it's nontrivial to determine whether the broken > image is broken in an expected way or in an unexpected way. > > This change teaches the Shindig-Caja URI policy what to do with these > relative URIs in these sample gadgets, so that the images render correctly. > > (CSS background images are also broken, in a different way. This change does > not fix that.) > > > Diffs > ----- > > /trunk/features/src/main/javascript/features/caja/taming.js 1131194 > > Diff: https://reviews.apache.org/r/854/diff > > > Testing > ------- > > 'mvn test' passes. > Without this change, SocialHelloWorld.xml has broken "nophoto" images when > cajoled. > With this change, SocialHelloWorld.xml has correct "nophoto" images when > cajoled. > > > Thanks, > > Felix > >
