Thanks, for the review guys. Will commit this in 5 minutes if no more comment/ suggestion.
- Henry On Tue, Jun 21, 2011 at 10:57 AM, Henry Saputra <[email protected]> wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/939/ > Review request for shindig. > By Henry Saputra. > > *Updated 2011-06-21 17:57:51.568557* > Changes > > Update as suggested by Paul. > > Description > > Remove scheme from default test domain/host name in the config/container.js. > > Also make the gadgets.uri.iframe.unlockedDomain is free from // and add it in > the default Iframe URL manager to avoid opaque URL. > > Testing > > Modify unit test. > > Diffs (updated) > > - trunk/config/container.js (1137864) > - > trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java > (1137864) > - > trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManagerTest.java > (1137864) > > View Diff <https://reviews.apache.org/r/939/diff/> >
