----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1080/#review1028 -----------------------------------------------------------
Ship it! LGTM - Mat On 2011-07-11 19:06:46, johnfargo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1080/ > ----------------------------------------------------------- > > (Updated 2011-07-11 19:06:46) > > > Review request for shindig. > > > Summary > ------- > > Also includes all/new/loaded feature computation in JsRequest, as a useful > convenience. > > This CL adds support for the supportDefer="true" annotation in <api>. In its > presence, the exportJs() calls generated by ExportJsProcessor are augmented > to request deferred symbol binding when &jsload=1. This in turn allows > support for synchronously enqueueing requests to symbols whose full > implementations haven't yet been loaded. > > > Diffs > ----- > > > trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/ExportJsProcessor.java > 1144361 > > trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/JsRequest.java > 1144361 > > trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/JsRequestBuilder.java > 1144361 > > trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/JsServingPipelineModule.java > 1144361 > > trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java > 1144361 > > trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/js/ExportJsProcessorTest.java > 1144361 > > trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/js/JsRequestBuilderTest.java > 1144361 > > trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java > 1144361 > > trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java > 1144361 > > trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/JsServletTest.java > 1144361 > > Diff: https://reviews.apache.org/r/1080/diff > > > Testing > ------- > > > Thanks, > > johnfargo > >
