> On 2011-07-11 22:52:50, Michael Hermanto wrote: > > trunk/features/src/main/javascript/features/exportjs/exportjs.js, line 48 > > <https://reviews.apache.org/r/1077/diff/1/?file=22245#file22245line48> > > > > Deserve some javadoc here. What you wrote to me is good.
Added. > On 2011-07-11 22:52:50, Michael Hermanto wrote: > > trunk/features/src/main/javascript/features/exportjs/exportjs.js, line 51 > > <https://reviews.apache.org/r/1077/diff/1/?file=22245#file22245line51> > > > > Looks a little strange that this is tied to ___jsl/jsloader (google > > only at this point). I understand that you want to keep a global state of > > has been deferred and deferred-loaded throughout a page session. I agree -- though I figure it doesn't matter much since the main requirement is to store data in some global state to guard against dual inclusion bugs. We will probably want to propose contributing jsloader at some point too. - johnfargo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1077/#review1030 ----------------------------------------------------------- On 2011-07-11 18:49:13, johnfargo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1077/ > ----------------------------------------------------------- > > (Updated 2011-07-11 18:49:13) > > > Review request for shindig. > > > Summary > ------- > > Add ability to optionally create deferred symbols in exportJs function call. > > In the presence of a (boolean) opt_defer 4th parameter to exportJs, stub > methods are created for all nonexistent exports. Each stub method enqueues > its arguments and returns immediately. When "actual" symbols are exported at > a later time, this deferred map is consulted. When it exists, its contents > are exported with the "full" method dispatched on the arguments. > > Additional CLs will provide ways to programmatically utilize this > functionality. > > > Diffs > ----- > > trunk/features/src/main/javascript/features/exportjs/exportjs.js 1144361 > > Diff: https://reviews.apache.org/r/1077/diff > > > Testing > ------- > > > Thanks, > > johnfargo > >
