----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1104/#review1048 -----------------------------------------------------------
Ship it! /trunk/content/samplecontainer/examples/commoncontainer/assembler.js <https://reviews.apache.org/r/1104/#comment2121> can you remove trailing spaces? lgtm - Paul On 2011-07-13 21:10:15, Matt Marum wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1104/ > ----------------------------------------------------------- > > (Updated 2011-07-13 21:10:15) > > > Review request for shindig. > > > Summary > ------- > > This was inadvertently removed in a previous revision. Not having the inline > client prevents the container from being able to send events to gadgets. This > breaks some of the functionality in the sample CommonContainer. > > > Diffs > ----- > > /trunk/content/samplecontainer/examples/commoncontainer/assembler.js > 1145681 > > Diff: https://reviews.apache.org/r/1104/diff > > > Testing > ------- > > Ran JUnits and functional testing by sending container events using > http://localhost:8080/samplecontainer/examples/commoncontainer/ > > > Thanks, > > Matt > >
