----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1107/#review1055 -----------------------------------------------------------
Ship it! LGTM - Paul On 2011-07-14 15:27:31, johnfargo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1107/ > ----------------------------------------------------------- > > (Updated 2011-07-14 15:27:31) > > > Review request for shindig, Ziv Horesh and Michael Hermanto. > > > Summary > ------- > > This error is functionally pointless and in a number of circumstances just > makes it more difficult to use the JS functionality in Shindig. > > The config value still remains for URI generation. > > > Diffs > ----- > > > trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java > 1145744 > > trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultJsUriManagerTest.java > 1145744 > > Diff: https://reviews.apache.org/r/1107/diff > > > Testing > ------- > > > Thanks, > > johnfargo > >
