Cool, thx. Committed as rev 1147015.
- Henry On Thu, Jul 14, 2011 at 5:24 PM, Ryan J Baxter <[email protected]> wrote: > +1 to the caching. I don't have a problem with it. > > -Ryan > > Email: [email protected] > Phone: 978-899-3041 > developerWorks Profile > > > > From: Henry Saputra <[email protected]> > To: [email protected], > Date: 07/13/2011 10:17 PM > Subject: Re: Setting > shindig.gadget-rewrite.externalize-feature-libs=true in shindig.properties > by default > > > > Forgot to put link for the performance claim: > http://developer.yahoo.com/performance/rules.html#external > > - Henry > > On Wed, Jul 13, 2011 at 7:03 PM, Henry Saputra <[email protected]> > wrote: >> One advantage is that the javascript could be cached so different >> gadgets having the same features should not require request to server >> to get it again. >> >> Second, Fargo or Michael could correct me on this, the JS serving path >> via JsServlet allow JS compiler via closure and JS processor flow to >> process the javascript code to be more efficient. I dont think the >> inline script will go through the same path. >> >> - Henry >> >> On Wed, Jul 13, 2011 at 6:02 PM, Ryan J Baxter <[email protected]> > wrote: >>> So what's the benefit of doing this? Just trying to understand why > this >>> would be better. >>> >>> -Ryan >>> >>> Email: [email protected] >>> Phone: 978-899-3041 >>> developerWorks Profile >>> >>> >>> >>> From: Henry Saputra <[email protected]> >>> To: [email protected], >>> Date: 07/12/2011 11:11 PM >>> Subject: Re: Setting >>> shindig.gadget-rewrite.externalize-feature-libs=true in > shindig.properties >>> by default >>> >>> >>> >>> Hi Ryan, >>> >>> Yes, there will be script tag with src attribute that points to >>> JsServlet for the gadget features. >>> >>> - Henry >>> >>> On Tue, Jul 12, 2011 at 6:43 PM, Ryan J Baxter <[email protected]> >>> wrote: >>>> Henry, as a result of your proposed change would we put a script tag >>> with >>>> a src attribute in it as opposed to putting the javascript inline in > the >>>> gadget? >>>> >>>> -Ryan >>>> >>>> Email: [email protected] >>>> Phone: 978-899-3041 >>>> developerWorks Profile >>>> >>>> >>>> >>>> From: Henry Saputra <[email protected]> >>>> To: [email protected], >>>> Date: 07/12/2011 06:26 PM >>>> Subject: Setting >>>> shindig.gadget-rewrite.externalize-feature-libs=true in >>> shindig.properties >>>> by default >>>> >>>> >>>> >>>> HI All, >>>> >>>> If there is no objection I would like to set >>>> shindig.gadget-rewrite.externalize-feature-libs in shindig.properties >>>> to true. >>>> >>>> Its currently set to false which I think because some issue with JS >>>> handler code. >>>> >>>> With a lot of changes to the JavaScript serving code, setting the >>>> shindig.gadget-rewrite.externalize-feature-libs to true will help run >>>> the code not only for container but also for gadget features. >>>> >>>> - Henry >>>> >>>> >>>> >>>> >>> >>> >>> >>> >> > > > >
