----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1085/ -----------------------------------------------------------
(Updated 2011-07-20 01:54:37.114849) Review request for shindig and Paul Lindner. Changes ------- Fixed bug in navigateUrl_ Summary ------- Adds the embedded experiences feature to Shindig. Moved code review to Apache from codereview.appspot. Original review is here http://codereview.appspot.com/4631090/. Issue: https://issues.apache.org/jira/browse/SHINDIG-1453. Note: The reference implementation included in this patch is dependent on another patch to the views feature. However the embedded experiences feature code is not so it should build fine. The views changes depend on the embedded experience feature so this feature must be committed first. Diffs (updated) ----- http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/index.html PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/content/sampledata/canonicaldb.json 1148551 http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1148551 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/constant.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/feature.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1148551 http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/embeddedexperiences/embedded_experiences_container_test.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryAtomId.xml 1148551 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryAtomIds.xml 1148551 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonDelete.json 1148551 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json 1148551 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonId.json 1148551 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json 1148551 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlId.xml 1148551 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlIds.xml 1148551 Diff: https://reviews.apache.org/r/1085/diff Testing ------- Unit tests and reference implementation Thanks, Ryan
