----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1154/#review1143 -----------------------------------------------------------
Ship it! LGTM - Stanton On 2011-07-20 21:49:10, Ryan Baxter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1154/ > ----------------------------------------------------------- > > (Updated 2011-07-20 21:49:10) > > > Review request for shindig and Paul Lindner. > > > Summary > ------- > > If you call CommonContainer.ee.navigate and pass a navigate callback and the > embedded experience contains a gadget url which is not reachable the callback > will be called with the result object from preloading that gadget. It should > be called with just the metadata for that gadget and not the whole result. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js > 1148946 > > Diff: https://reviews.apache.org/r/1154/diff > > > Testing > ------- > > Testing done in reference implementation and unit tests pass. > > > Thanks, > > Ryan > >
