Thanks! Will commit after yours :) On Tue, Aug 2, 2011 at 1:09 PM, Michael Hermanto <[email protected]>wrote:
> > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1237/#review1271 > ----------------------------------------------------------- > > Ship it! > > > ... upon fix. > > - Michael > > > On 2011-08-02 00:57:26, johnfargo wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/1237/ > > ----------------------------------------------------------- > > > > (Updated 2011-08-02 00:57:26) > > > > > > Review request for shindig and Michael Hermanto. > > > > > > Summary > > ------- > > > > The previous model of using exportJs() for both deferred and actual > symbol exports turned out to be faulty due to the fact that top-level/global > arguments are not properties. As well, splitting export() and defer() makes > the relevant functionality more compact where actually used, and more > explicit. > > > > This CL reverts the exportJs() changes that bind deferred symbols, though > keeps the deferred method execution intact. > > > > It splits out deferred symbol binding into a new method, deferJs(), while > doing so. The two methods work in concert with one another, communicating > through ___jsl.dm. > > > > > > Diffs > > ----- > > > > trunk/features/src/main/javascript/features/deferjs/deferjs.js > PRE-CREATION > > trunk/features/src/main/javascript/features/deferjs/feature.xml > PRE-CREATION > > trunk/features/src/main/javascript/features/exportjs/exportjs.js > 1152380 > > trunk/features/src/main/javascript/features/features.txt 1152380 > > > > Diff: https://reviews.apache.org/r/1237/diff > > > > > > Testing > > ------- > > > > CL sent for early review. Doing more testing now in real-world scenarios. > > > > > > Thanks, > > > > johnfargo > > > > > >
