----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1505/#review1463 -----------------------------------------------------------
LGTM, could you please create a JIRA for this? - Ryan On 2011-08-15 20:25:22, Jason Chiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1505/ > ----------------------------------------------------------- > > (Updated 2011-08-15 20:25:22) > > > Review request for shindig and Ryan Baxter. > > > Summary > ------- > > 1. Current openEE implementation in open-views feature cannot handle URL data > model > 2. The scroll bar is always visible when using the navigateUrl API, prefer to > change the scrolling settings from "yes" to "auto". > > Link to JIRA: https://issues.apache.org/jira/browse/SHINDIG-1573 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml > 1157881 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/url_holder.js > 1157881 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js > 1157948 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_holder_test.js > 1157881 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_site_test.js > 1157881 > > Diff: https://reviews.apache.org/r/1505/diff > > > Testing > ------- > > Test done on embedded experience sample container with sample gadget, passed > jsUnit test. > > > Thanks, > > Jason > >
