----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1578/#review1515 -----------------------------------------------------------
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/DefaultServiceFetcher.java <https://reviews.apache.org/r/1578/#comment3463> Small nit, the variable endpointVal could just be put inside the for loop since its not used outside. - Henry On 2011-08-17 21:21:53, li xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1578/ > ----------------------------------------------------------- > > (Updated 2011-08-17 21:21:53) > > > Review request for shindig, Paul Lindner, Henry Saputra, johnfargo, and Eric > Woods. > > > Summary > ------- > > We have to manually configure following property to enable Shindig to support > "https" request. > > "osapi" : { > // The endpoints to query for available JSONRPC/REST services > "endPoints" : [ "http://%host%${CONTEXT_ROOT}/rpc"; ] > }, > > By default, it's "http". > It should be able to allow http and https request at the sametime. > > > This fix would enable server side to automatically resolve the scheme and > also enable client side to use schemeless osapi service endpoints. > The configuration would be: > > "osapi" : { > // The endpoints to query for available JSONRPC/REST services > "endPoints" : [ "//%host%${CONTEXT_ROOT}/rpc" ] > }, > > DefaultServiceFetcher would automatically resolve the scheme. > jsonrpctransport would use "//%host%${CONTEXT_ROOT}/rpc" as endpoint url. > > > Diffs > ----- > > /trunk/config/container.js 1154054 > > /trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.java > 1146102 > > /trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java > 1146102 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/DefaultServiceFetcher.java > 1146102 > > Diff: https://reviews.apache.org/r/1578/diff > > > Testing > ------- > > Passed JUnit tests. > > Tested on Tomcat with SSL enabled. > > > Thanks, > > li > >
